Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 1132093003: Add metrics to record TCP/UDP connections made from Flash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_socket_utils.cc
diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
index 45d35ce4160cf14f653cbb1879bc0d00a607e031..faf859aa3be42a90e7427112862847dcb0d84567 100644
--- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc
+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
@@ -14,8 +14,11 @@
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/site_instance.h"
+#include "content/public/browser/user_metrics.h"
#include "content/public/common/content_client.h"
+#include "content/public/common/content_constants.h"
#include "net/cert/x509_certificate.h"
+#include "ppapi/c/pp_errors.h"
#include "ppapi/c/private/ppb_net_address_private.h"
#include "ppapi/shared_impl/private/net_address_private_impl.h"
#include "ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h"
@@ -128,5 +131,20 @@ bool GetCertificateFields(const char* der,
return GetCertificateFields(*cert.get(), fields);
}
+void RecordFlashConnectMetric(const std::string& plugin_module_name,
+ const GURL& plugin_url) {
+ // Only record Flash connections.
+ if (plugin_module_name != content::kFlashPluginName)
+ return;
+
+ if (plugin_url.SchemeIs(url::kHttpsScheme)) {
+ content::RecordAction(
+ base::UserMetricsAction("Flash_SocketConnect_Secure"));
+ } else {
+ content::RecordAction(
+ base::UserMetricsAction("Flash_SocketConnect_Insecure"));
+ }
+}
+
} // namespace pepper_socket_utils
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698