Add metrics to record TCP/UDP connections made from Flash

content/browser/renderer_host/pepper/pepper_socket_utils.h

Index: content/browser/renderer_host/pepper/pepper_socket_utils.h
diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.h b/content/browser/renderer_host/pepper/pepper_socket_utils.h
index e7bc1e3eb04102904db5ca5306c7e2f9dac14b85..e343c1942ff729673ce59da336735b41c0e01ab9 100644
--- a/content/browser/renderer_host/pepper/pepper_socket_utils.h
+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.h
@@ -10,6 +10,8 @@
 
 struct PP_NetAddress_Private;
 
+class GURL;
+
 namespace net {
 class X509Certificate;
 }
@@ -46,6 +48,10 @@ bool GetCertificateFields(const char* der,
                           uint32_t length,
                           ppapi::PPB_X509Certificate_Fields* fields);
 
+// Record socket connection metrics for flash.
+void RecordFlashConnectMetric(const std::string& plugin_module_name,

[raymes, 2015/05/11 06:44:21]

I was told that we're only interested in Flash? Do you want to know about the
stats including NaCl, etc?  

[jww, 2015/05/11 06:51:14]

From our perspective, I believe we're pretty much solely concerned about Flash.
I suppose there's no reason not to collect broader metrics though.

[Ryan Sleevi, 2015/05/11 07:07:43]

I don't think that's true, Joel.

That is, it applies broadly to all PPAPI plugins. From what I understand, it may
be that only Flash is auto-whitelisted, but given that there's at least a Peppet
API for sockets makes me want to make sure we are covering all plugins equally.

[jww, 2015/05/11 22:58:03]

From Tim and my perspective, we really do care specifically about Flash, since
it's broadly installed on virtually all machines, so that's where abuse and
bypass of other restrictions are likely to happen. However, if you see value in
measuring it across the board, that certainly seems fine to me.

[jww, 2015/05/11 23:25:12]

On second thought, this is definitely more general. We should definitely apply
this to all of PPAPI since, as sleevi pointed out, it could be done by anything
using the API.

+                              const GURL& plugin_url);
+
 }  // namespace pepper_socket_utils
 
 }  // namespace content