tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b13b369b4f61b5c71b0575e4c7a6cbc9620bfcd9..2c11153cd4731231c2e93e908b6c41e011495e4a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -26580,6 +26580,26 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Pepper.PluginContextSecurity.TCPConnect"
+    enum="PluginContextSecurity">
+  <owner>raymes@chromium.org</owner>
+  <owner>jww@chromium.org</owner>
+  <owner>rsleevi@chromium.org</owner>
+  <summary>
+    Number of Pepper TCP connect bind attempts from a plugin in a secure origin.

[Ilya Sherman, 2015/05/14 02:26:01]

nit: I'd phrase this as something closer to "Whether a Pepper TCP connect bind
attempt comes from a plugin in a secure or an insecure origin".  Definitely feel
free to reword; the main idea that I'm trying to convey is that this histogram
measures the possible security states of a connection attempt.

[raymes, 2015/05/14 02:47:44]

Done.

+  </summary>
+</histogram>
+
+<histogram name="Pepper.PluginContextSecurity.UDPBind"
+    enum="PluginContextSecurity">
+  <owner>raymes@chromium.org</owner>
+  <owner>jww@chromium.org</owner>
+  <owner>rsleevi@chromium.org</owner>
+  <summary>
+    Number of Pepper UDP socket bind attempts from a plugin in a secure origin.

[Ilya Sherman, 2015/05/14 02:26:01]

(Same idea applies here as well.)

[raymes, 2015/05/14 02:47:44]

Done.

+  </summary>
+</histogram>
+
 <histogram name="PerformanceMonitor.AverageCPU" units="PercentCPUUsage">
   <owner>oysteine@chromium.org</owner>
   <summary>
@@ -60190,6 +60210,11 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="2" label="PLUGIN_DISABLED"/>
 </enum>
 
+<enum name="PluginContextSecurity" type="int">
+  <int value="0" label="PLUGIN_CONTEXT_SECURE"/>
+  <int value="1" label="PLUGIN_CONTEXT_INSECURE"/>

[Ilya Sherman, 2015/05/14 02:26:01]

nit: You can use these labels if you'd like, but I'd recommend just "Secure" and
"Insecure", as they're more human-reader friendly.

[raymes, 2015/05/14 02:47:44]

Done. Can I keep the enum here with UMA_HISTOGRAM_BOOLEAN? Or should I change it
to a boolean type?

[Ilya Sherman, 2015/05/14 02:54:29]

You can keep the enum here.  UMA_HISTOGRAM_BOOLEAN is really just a special case
of UMA_HISTOGRAM_ENUMERATION.  The "BooleanFoo" enum types in this file are just
named such by convention.  That said, I probably would go with "BooleanSecure"
as the enum name in this case, since that's a concept that might be useful for
other histograms as well.  histograms.xml is just a metadata file that drives
the dashboard UI, so it's easy to rename the enum type later if need be.

[raymes, 2015/05/14 03:03:58]

Done.

Ahh that makes sense! Thanks!!

+</enum>
+
 <enum name="PluginGroup" type="int">
   <int value="0" label="Other Plugin"/>
   <int value="1" label="Adobe Reader"/>