Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9526)

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Issue 1132093003: Add metrics to record TCP/UDP connections made from Flash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
index f29fc977fe941c7c035940cdabc2f094dc62c42f..194667186f628cdedc368ac720995b7b8f9f1772 100644
--- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/location.h"
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "base/profiler/scoped_tracker.h"
#include "build/build_config.h"
#include "content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h"
@@ -1000,6 +1001,14 @@ void PepperTCPSocketMessageFilter::SendConnectReply(
int32_t pp_result,
const PP_NetAddress_Private& local_addr,
const PP_NetAddress_Private& remote_addr) {
+ pepper_socket_utils::PluginContextSecurity security =
+ host_->IsPotentiallySecurePluginContext(instance_)
+ ? pepper_socket_utils::PLUGIN_CONTEXT_SECURE
+ : pepper_socket_utils::PLUGIN_CONTEXT_INSECURE;
+ UMA_HISTOGRAM_ENUMERATION(
+ "Pepper.PluginContextSecurity.TCPConnect", security,
+ pepper_socket_utils::PLUGIN_CONTEXT_SECURITY_NUM_ENTRIES);
Ilya Sherman 2015/05/14 02:26:01 nit: Since you're currently tracking a boolean val
raymes 2015/05/14 02:47:44 Done.
+
ppapi::host::ReplyMessageContext reply_context(context);
reply_context.params.set_result(pp_result);
SendReply(reply_context,

Powered by Google App Engine
This is Rietveld 408576698