Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1132053005: Make KitkatCaptioningBridge a singleton (Closed)

Created:
5 years, 7 months ago by qinmin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make KitkatCaptioningBridge a singleton Currently each ContentViewCore creates a KitkatCaptioningBridge on K+ devices. And all of them listens to the system CaptioningManager. So whenever the system captioning changes, all ContentViewCores will have to handle it separately. This change simplifies that process by making KitkatCaptioningBridge a singleton. All ContentViewCores become listeners to that singleton. Whenever system captioning changes, a single CaptioningChangeDelegate class will handle the change. It will then inform all ContentViewCores that are alive. If all ContentViewCores are GC'ed, KitkatCaptioningBridge will stop listen to system CaptioningManager. BUG=457850 Committed: https://crrev.com/ef83a816a5494cc0eb6b6f6ae7a22464b7624f3d Cr-Commit-Position: refs/heads/master@{#330408}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unused singleton #

Messages

Total messages: 9 (3 generated)
qinmin
PTAL
5 years, 7 months ago (2015-05-15 23:46:20 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/1132053005/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java File content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java (right): https://chromiumcodereview.appspot.com/1132053005/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java#newcode12 content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java:12: private static EmptyCaptioningBridge sEmptyCaptioningBridge; remove?
5 years, 7 months ago (2015-05-18 14:01:24 UTC) #3
qinmin
https://codereview.chromium.org/1132053005/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java File content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java (right): https://codereview.chromium.org/1132053005/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java#newcode12 content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/EmptyCaptioningBridge.java:12: private static EmptyCaptioningBridge sEmptyCaptioningBridge; On 2015/05/18 14:01:24, David Trainor ...
5 years, 7 months ago (2015-05-18 18:29:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132053005/20001
5 years, 7 months ago (2015-05-18 18:31:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 20:45:39 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:42:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef83a816a5494cc0eb6b6f6ae7a22464b7624f3d
Cr-Commit-Position: refs/heads/master@{#330408}

Powered by Google App Engine
This is Rietveld 408576698