Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2360)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java

Issue 1132053005: Make KitkatCaptioningBridge a singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unused singleton Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java
index 69372c4b142eb8983000d8ab651037b32a039685..1d09cf056f6f1bdd9e9cc51d6d29c8e03726dd7e 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningBridgeFactory.java
@@ -4,10 +4,9 @@
package org.chromium.content.browser.accessibility.captioning;
+import android.content.Context;
import android.os.Build;
-import org.chromium.content.browser.ContentViewCore;
-
/**
* Returns the best captions bridge available. If the API level is lower than KitKat, a no-op
* bridge is returned since those systems didn't support this functionality.
@@ -16,12 +15,12 @@ public class CaptioningBridgeFactory {
/**
* Create and return the best SystemCaptioningBridge available.
*
- * @param contentViewCore the ContentViewCore to create the bridge with
+ * @param context Context associated with the activity.
* @return the best SystemCaptioningBridge available.
*/
- public static SystemCaptioningBridge create(ContentViewCore contentViewCore) {
+ public static SystemCaptioningBridge getSystemCaptioningBridge(Context context) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
- return new KitKatCaptioningBridge(contentViewCore);
+ return KitKatCaptioningBridge.getInstance(context);
}
// On older systems, return a CaptioningBridge that does nothing.
return new EmptyCaptioningBridge();

Powered by Google App Engine
This is Rietveld 408576698