Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1132033002: [turbofan] Float32Abs and Float64Abs are supported by all backends. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Float32Abs and Float64Abs are supported by all backends. The Float32Abs and Float64Abs operators are supported by all TurboFan backends, so we no longer need the flags for them. R=jarin@chromium.org Committed: https://crrev.com/189609e197d03369e0bcc4d32e88fe56ef2b6af1 Cr-Commit-Position: refs/heads/master@{#28310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -47 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +10 lines, -14 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-08 04:40:57 UTC) #1
Benedikt Meurer
Hey Jaro, This is trivial cleanup. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-08 04:41:27 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-08 08:11:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132033002/1
5 years, 7 months ago (2015-05-08 08:22:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 08:25:07 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 08:25:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189609e197d03369e0bcc4d32e88fe56ef2b6af1
Cr-Commit-Position: refs/heads/master@{#28310}

Powered by Google App Engine
This is Rietveld 408576698