Fixing guest processes to use the proper storage partition.

Fixing guest processes to use the proper storage partition.

BUG=158128

[awong, 2012-10-27 00:10:52]

As discussed, we still need to modify StoragePartition::Create()

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.cc:1613: if
(!url.SchemeIs(chrome::kGuestScheme)) {
Should this be whitelist instead?  SchemeIs(chrome::kExtensionScheme)?

[Fady Samuel, 2012-10-27 00:16:00]

A couple of superficial nits.

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/web_view_browsertest.cc (right):

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/web_view_browsertest.cc:107: // declaration into the
same in-memory partition. Test the browser tags to
nit: webview tags.

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/profiles/of...
File chrome/browser/profiles/off_the_record_profile_impl.cc (left):

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/profiles/of...
chrome/browser/profiles/off_the_record_profile_impl.cc:280: // For guest
processes (used by the browser tag), we need to isolate the
nit: webview tag :P

[nasko, 2012-10-27 00:28:12]

Adding OWNERS reviewers:

aa@ for chrome/browser/extensions
mmenke@ for chrome/browser/profiles 
creis@ for content/

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/11320018/diff/2001/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.cc:1613: if
(!url.SchemeIs(chrome::kGuestScheme)) {
On 2012/10/27 00:10:52, awong wrote:
> Should this be whitelist instead?  SchemeIs(chrome::kExtensionScheme)?

Since this is very rushed CL, I'd rather be more defensive on this one.

[Charlie Reis, 2012-10-27 00:48:27]

Albert is making changes to this in a different CL, so Aaron and Matt should
hold off.  We'll need owner's approvals on Albert's version instead.

https://codereview.chromium.org/11320018/diff/2002/chrome/browser/extensions/...
File chrome/browser/extensions/web_view_browsertest.cc (right):

https://codereview.chromium.org/11320018/diff/2002/chrome/browser/extensions/...
chrome/browser/extensions/web_view_browsertest.cc:91:
source2->GetWebContents()->GetRenderProcessHost()->GetStoragePartition());
The real bug was that the guest's StoragePartition was the same as the default
one.  Can we verify that they're not the same?

https://codereview.chromium.org/11320018/diff/2002/content/browser/storage_pa...
File content/browser/storage_partition_impl.cc (right):

https://codereview.chromium.org/11320018/diff/2002/content/browser/storage_pa...
content/browser/storage_partition_impl.cc:100: bool in_memory =
(partition_id.find("guest-") != std::string::npos) ||
Albert noted this shouldn't use find.

https://codereview.chromium.org/11320018/diff/2002/content/browser/storage_pa...
content/browser/storage_partition_impl.cc:101: context->IsOffTheRecord();
nit: Wrong indent.

[awong, 2012-10-27 00:49:13]

FYI, I'm picking up from Nasko.  Moving review to 
https://codereview.chromium.org/11308024

[mmenke, 2012-10-27 00:59:19]

Per the owners file, I'm only a profile owner for the networking stuff (Mostly
ProfileIOData)

[Aaron Boodman, 2012-10-30 05:35:08]

c/b/e lgtm