Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1131963004: Cherry pick "Speculative fix for AVX2 detection" (Closed)

Created:
5 years, 7 months ago by Johann
Modified:
5 years, 7 months ago
Reviewers:
CC:
wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@m43-2357
Target Ref:
refs/heads/m43-2357
Visibility:
Public.

Description

Cherry pick "Speculative fix for AVX2 detection" In master since 2386: https://codereview.chromium.org/1104213004 Crashes on non-avx2 processors point to possible misdetection. Cherry pick https://chromium-review.googlesource.com/267345 x86_simd_caps: check max cpuid before testing AVX2 structured extended feature flags require eax = 7; avoids incorrectly detecting avx2 on some older processors that support avx. from [1]: INPUT EAX = 0: Returns CPUID’s Highest Value for Basic Processor Information and the Vendor Identification String [1] http://www.intel.com/content/www/us/en/processors/processor-identification BUG=480586 Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/ea4ce75ca4525ad42dd90b2a210f99bd2b3a7c03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M source/libvpx/vpx_ports/x86.h View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Johann
5 years, 7 months ago (2015-05-07 18:43:25 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea4ce75ca4525ad42dd90b2a210f99bd2b3a7c03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698