Issue 1104213004: Speculative fix for AVX2 detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1104213004: Speculative fix for AVX2 detection (Closed)

Created:
5 years, 8 months ago by Johann

Modified:
5 years, 7 months ago

Reviewers:
jzern, Tom Finegan

CC:
wwcv, fgalligan1, Tom Finegan

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Speculative fix for AVX2 detection Crashes on non-avx2 processors point to possible misdetection. Cherry pick https://chromium-review.googlesource.com/267345 x86_simd_caps: check max cpuid before testing AVX2 structured extended feature flags require eax = 7; avoids incorrectly detecting avx2 on some older processors that support avx. from [1]: INPUT EAX = 0: Returns CPUID’s Highest Value for Basic Processor Information and the Vendor Identification String [1] http://www.intel.com/content/www/us/en/processors/processor-identification TBR=tomfinegan@chromium.org BUG=480586 Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/471ce88a3ab02b1cdc99ebdc0ecf0e361b92c3be

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	source/libvpx/vpx_ports/x86.h	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Johann

James - any objection to landing this so it can start soaking to see if ...

5 years, 8 months ago (2015-04-27 21:07:14 UTC) #1

jzern

On 2015/04/27 21:07:14, Johann wrote: > James - any objection to landing this so it ...

5 years, 7 months ago (2015-04-28 21:31:31 UTC) #2

Johann

5 years, 7 months ago (2015-04-28 21:32:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
471ce88a3ab02b1cdc99ebdc0ecf0e361b92c3be (presubmit successful).