Switch //net functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

net/http/http_network_transaction.cc

Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 981fcb6abb003efef8362d272967df28d96309e0..821cf3d1603c2bd87f45402c83ef8fca74d77aaf 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -590,7 +590,7 @@ void HttpNetworkTransaction::GetConnectionAttempts(
 }
 
 bool HttpNetworkTransaction::IsSecureRequest() const {
-  return request_->url.SchemeIsSecure();
+  return request_->url.SchemeIsCryptographic();

[Ryan Hamilton, 2015/05/07 23:12:03]

I'm not sure about this change. Has someone walked up the stack to see if
IsSecureRequest is expected to return true for file:// URLs?

[lgarron, 2015/05/08 01:53:30]

It's used in two places in the same function,
HttpNetworkTransaction::DoReadHeadersComplete():

- As a DCHECK when client certs are needed [1].
- As a check before getting SSL info [2].

I think it's safe to say that this this is only relevant to HTTPS.

[1]
https://chromium.googlesource.com/chromium/src/+/ca9d6916c5fedf6f0ee73dfc397c...
[2]
https://chromium.googlesource.com/chromium/src/+/ca9d6916c5fedf6f0ee73dfc397c...

[asanka, 2015/05/11 22:00:46]

I'm tempted to say we should rename this fairly visible method to match the test
being performed. E.g. IsSecureRequest -> IsRequestedOverEncryptedChannel(). I
suck at naming things.

[lgarron, 2015/05/11 23:23:47]

IsEncryptedRequest()?

[asanka, 2015/05/12 17:00:17]

Sure.

 }
 
 bool HttpNetworkTransaction::UsingHttpProxyWithoutTunnel() const {