Switch //net functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 572 matching lines @@
   stream_request_.reset();  // we're done with the stream request
   OnIOComplete(ERR_HTTPS_PROXY_TUNNEL_RESPONSE);
 }
 
 void HttpNetworkTransaction::GetConnectionAttempts(
     ConnectionAttempts* out) const {
   *out = connection_attempts_;
 }
 
 bool HttpNetworkTransaction::IsSecureRequest() const {
-  return request_->url.SchemeIsSecure();
+  return request_->url.SchemeIsCryptographic();

[Ryan Hamilton, 2015/05/07 23:12:03]

I'm not sure about this change. Has someone walked up the stack to see if
IsSecureRequest is expected to return true for file:// URLs?

[lgarron, 2015/05/08 01:53:30]

It's used in two places in the same function,
HttpNetworkTransaction::DoReadHeadersComplete():

- As a DCHECK when client certs are needed [1].
- As a check before getting SSL info [2].

I think it's safe to say that this this is only relevant to HTTPS.

[1]
https://chromium.googlesource.com/chromium/src/+/ca9d6916c5fedf6f0ee73dfc397c...
[2]
https://chromium.googlesource.com/chromium/src/+/ca9d6916c5fedf6f0ee73dfc397c...

[asanka, 2015/05/11 22:00:46]

I'm tempted to say we should rename this fairly visible method to match the test
being performed. E.g. IsSecureRequest -> IsRequestedOverEncryptedChannel(). I
suck at naming things.

[lgarron, 2015/05/11 23:23:47]

IsEncryptedRequest()?

[asanka, 2015/05/12 17:00:17]

Sure.

 }
 
 bool HttpNetworkTransaction::UsingHttpProxyWithoutTunnel() const {
   return (proxy_info_.is_http() || proxy_info_.is_https() ||
           proxy_info_.is_quic()) &&
          !(request_->url.SchemeIs("https") || request_->url.SchemeIsWSOrWSS());
 }
 
 void HttpNetworkTransaction::DoCallback(int rv) {
   DCHECK_NE(rv, ERR_IO_PENDING);
@@ skipping 1018 matching lines @@
   DCHECK(stream_request_);
 
   // Since the transaction can restart with auth credentials, it may create a
   // stream more than once. Accumulate all of the connection attempts across
   // those streams by appending them to the vector:
   for (const auto& attempt : stream_request_->connection_attempts())
     connection_attempts_.push_back(attempt);
 }
 
 }  // namespace net