Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1131953003: Use Linux custom baud rate selection based on struct termios2. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Linux custom baud rate selection based on struct termios2. This new mechanism is preferred as it is supported by newer Linux serial UART drivers such as TI OMAP. BUG=422165 TEST=Wired together FTDI and CP2102 USB serial adapters and tried standard and non-standard bitrates. Committed: https://crrev.com/3ecad604443848aed3091641652f1c943cb212a7 Cr-Commit-Position: refs/heads/master@{#329016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M device/serial/serial_io_handler_posix.cc View 4 chunks +29 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 7 months ago (2015-05-07 20:30:19 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-08 19:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131953003/1
5 years, 7 months ago (2015-05-08 19:34:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 19:39:20 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 19:40:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ecad604443848aed3091641652f1c943cb212a7
Cr-Commit-Position: refs/heads/master@{#329016}

Powered by Google App Engine
This is Rietveld 408576698