Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issue 1131893003: ui/gfx: Disable the failing ColorAnalysisTest tests on Android. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, alokp, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: Disable the failing ColorAnalysisTest tests on Android. After adding gfx_unittests test suite to Android tests FYI bot, we discover that these tests were failing there. We are disabling them in order to try to turn the bot green again. http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28trial%29%28dbg%29/builds/48/steps/gfx_unittests/logs/stdio BUG=None TEST=gfx_unittests on android R=danakj@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M ui/gfx/color_analysis_unittest.cc View 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
5 years, 7 months ago (2015-05-13 21:30:03 UTC) #1
danakj
Are you able to explain the failure at all?
5 years, 7 months ago (2015-05-13 21:32:11 UTC) #2
tfarina
No. They are like: ../../ui/gfx/color_analysis_unittest.cc:308: Failure Value of: ChannelApproximatelyEqual(100, SkColorGetR(color)) Actual: false Expected: true ../../ui/gfx/color_analysis_unittest.cc:372: ...
5 years, 7 months ago (2015-05-13 21:37:05 UTC) #3
danakj
5 years, 7 months ago (2015-05-14 17:19:19 UTC) #4
On 2015/05/13 21:37:05, tfarina wrote:
> No.
> 
> They are like:
> ../../ui/gfx/color_analysis_unittest.cc:308: Failure
> Value of: ChannelApproximatelyEqual(100, SkColorGetR(color))
>   Actual: false
> Expected: true
> 
> ../../ui/gfx/color_analysis_unittest.cc:372: Failure
> Value of: min_gl
>   Actual: '\xFF' (255)
> Expected: 145
> 
> ../../ui/gfx/color_analysis_unittest.cc:453: Failure
> Value of: max_gl
>   Actual: '\x80' (128)
> Expected: 127

Would you mind trying to figure out what is wrong for a bit before we just
disable them? Also can you please file a bug and point the disables over to it?

Powered by Google App Engine
This is Rietveld 408576698