src/arm/debug-arm.cc - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/debug-arm.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/debug-arm.cc

diff --git a/src/arm/debug-arm.cc b/src/arm/debug-arm.cc

index d9c25c6588c6a64cec29709d9443cf6541d4b39f..68ae773b6a12d2d32e7b3f9cb0015deae4522f77 100644

--- a/src/arm/debug-arm.cc

+++ b/src/arm/debug-arm.cc

@@ -267,7 +267,7 @@ void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {

StandardFrameConstants::kConstantPoolOffset - kPointerSize));

// Pop return address, frame and constant pool pointer (if

- // FLAG_enable_ool_constant_pool).

+ // FLAG_enable_embedded_constant_pool).

__ LeaveFrame(StackFrame::INTERNAL);

{ ConstantPoolUnavailableScope constant_pool_unavailable(masm);