src/arm/constants-arm.h - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/constants-arm.h

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/constants-arm.h

diff --git a/src/arm/constants-arm.h b/src/arm/constants-arm.h

index af68fb24e2c91280bb0bb5134d8563a8651776e8..7b8529c4bb7df324eab5c9b60fb4dcf7e61ea797 100644

--- a/src/arm/constants-arm.h

+++ b/src/arm/constants-arm.h

@@ -42,6 +42,11 @@ const int kNumVFPRegisters = kNumVFPSingleRegisters + kNumVFPDoubleRegisters;

const int kPCRegister = 15;

const int kNoRegister = -1;

+// Used in embedded constant pool builder - max reach in bits for

+// various load instructions (unsigned)

+const int kLdrMaxReachBits = 12;

+const int kVldrMaxReachBits = 10;

// -----------------------------------------------------------------------------

// Conditions.