Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: src/compiler/code-generator.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index 13087ec0aa1f76a4473fe11c5366eaceaae1851f..e6c84463063c24204bb7b9c249edeb0056d7bc17 100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -128,6 +128,10 @@ Handle<Code> CodeGenerator::GenerateCode() {
}
}
+ if (FLAG_enable_embedded_constant_pool) {
+ AssembleConstantPool();
rmcilroy 2015/05/20 14:32:11 Do we need this here too if we are doing it in Get
MTBrandyberry 2015/05/20 22:28:22 See earlier response.
+ }
+
safepoints()->Emit(masm(), frame()->GetSpillSlotCount());
Handle<Code> result = v8::internal::CodeGenerator::MakeCodeEpilogue(
@@ -657,6 +661,11 @@ void CodeGenerator::AssembleJumpTable(Label** targets, size_t target_count) {
#endif // !V8_TURBOFAN_BACKEND
+#if !V8_TURBOFAN_BACKEND || !V8_EMBEDDED_CONSTANT_POOL
+
+void CodeGenerator::AssembleConstantPool() { UNIMPLEMENTED(); }
+
+#endif // !V8_TURBOFAN_BACKEND || !V8_EMBEDDED_CONSTANT_POOL
OutOfLineCode::OutOfLineCode(CodeGenerator* gen)
: masm_(gen->masm()), next_(gen->ools_) {

Powered by Google App Engine
This is Rietveld 408576698