Embedded constant pools.

src/compiler/code-generator.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/pipeline.h"
 
@@ skipping 110 matching lines @@
 
   // Emit the jump tables.
   if (jump_tables_) {
     masm()->Align(kPointerSize);
     for (JumpTable* table = jump_tables_; table; table = table->next()) {
       masm()->bind(table->label());
       AssembleJumpTable(table->targets(), table->target_count());
     }
   }
 
+  if (FLAG_enable_embedded_constant_pool) {
+    AssembleConstantPool();

[rmcilroy, 2015/05/20 14:32:11]

Do we need this here too if we are doing it in GetCode? It seems like there are
quite a few places we are emitting the constant pools when ideally I would hope
there only needed to be a single place in GetCode().

[MTBrandyberry, 2015/05/20 22:28:22]

See earlier response.

+  }
+
   safepoints()->Emit(masm(), frame()->GetSpillSlotCount());
 
   Handle<Code> result = v8::internal::CodeGenerator::MakeCodeEpilogue(
       masm(), info->flags(), info);
   result->set_is_turbofanned(true);
   result->set_stack_slots(frame()->GetSpillSlotCount());
   result->set_safepoint_table_offset(safepoints()->GetCodeOffset());
 
   // Emit exception handler table.
   if (!handlers_.empty()) {
@@ skipping 509 matching lines @@
 
 void CodeGenerator::AddNopForSmiCodeInlining() { UNIMPLEMENTED(); }
 
 
 void CodeGenerator::AssembleJumpTable(Label** targets, size_t target_count) {
   UNIMPLEMENTED();
 }
 
 #endif  // !V8_TURBOFAN_BACKEND
 
+#if !V8_TURBOFAN_BACKEND || !V8_EMBEDDED_CONSTANT_POOL
+
+void CodeGenerator::AssembleConstantPool() { UNIMPLEMENTED(); }
+
+#endif  // !V8_TURBOFAN_BACKEND || !V8_EMBEDDED_CONSTANT_POOL
 
 OutOfLineCode::OutOfLineCode(CodeGenerator* gen)
     : masm_(gen->masm()), next_(gen->ools_) {
   gen->ools_ = this;
 }
 
 
 OutOfLineCode::~OutOfLineCode() {}
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8