Add close button to the supervised user pages.

Add close button to the supervised user pages.

BUG=487351
TEST=manual

Committed: https://crrev.com/f54b8097a9c45ed4ad308133d49f05325d6c5070
Cr-Commit-Position: refs/heads/master@{#330231}

[achuithb, 2015-05-15 00:41:21]

achuith@chromium.org changed reviewers:
+ antrim@chromium.org

[achuithb, 2015-05-15 00:41:22]

Denis, do you have any idea why this code doesn't work?

I can confirm that the event handler is correct. In the debug console, if I do 
$('close-button-item').click(), it executes correctly, but if I physically click
on the button, the event does not propagate to the event handler.

I'm guessing there's some polymer voodoo that's stealing the event.

[achuithb, 2015-05-15 01:19:41]

Patchset #2 (id:20001) has been deleted

[achuithb, 2015-05-15 01:19:59]

achuith@chromium.org changed reviewers:
+ dzhioev@chromium.org

[achuithb, 2015-05-15 01:20:00]

ok, this should be working now. Please review.

[achuithb, 2015-05-15 01:20:07]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 01:21:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131683004/40001

[commit-bot: I haz the power, 2015-05-15 01:52:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 01:52:56]

Dry run: This issue passed the CQ dry run.

[dzhioev (left Google), 2015-05-15 02:35:09]

Hello,
1. I believe your chromium checkout is outdated.
I removed IDR_LOGIN_CLOSE_BUTTTON_* from repository recently, as it is not
needed anymore.
You should use <button is="gaia-icon-button" icon="close"></button> (see such
button on GAIA screen
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
)
"gaia-icon-button" encapsulates all needed CSS styles for focused, active and
hover states. So you only need to position it and set a color (with "color" CSS
property).
Correct color for dark background is 'white', for white background -- rgba(0, 0,
0, .54).
2. I think we should hide the button on the last step of flow. This can be done
in setVisiblePage_ method.

[dzhioev (left Google), 2015-05-15 02:35:20]

https://codereview.chromium.org/1131683004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
(right):

https://codereview.chromium.org/1131683004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js:622:
e.preventDefault();
This trick is not needed for "gaia-icon-button" as well

[Denis Kuznetsov (DE-MUC), 2015-05-15 16:51:02]

lgtm
nit: see dzhioev@ comment.

[achuithb, 2015-05-15 22:05:24]

Patchset #3 (id:60001) has been deleted

[achuithb, 2015-05-15 22:09:30]

Patchset #3 (id:80001) has been deleted

[achuithb, 2015-05-15 22:10:15]

PTAL Pavel, I've addressed your comments.

https://codereview.chromium.org/1131683004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
(right):

https://codereview.chromium.org/1131683004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js:622:
e.preventDefault();
On 2015/05/15 02:35:20, dzhioev wrote:
> This trick is not needed for "gaia-icon-button" as well

Done.

[achuithb, 2015-05-15 22:10:36]

On 2015/05/15 02:35:09, dzhioev wrote:
> Hello,
> 1. I believe your chromium checkout is outdated.
> I removed IDR_LOGIN_CLOSE_BUTTTON_* from repository recently, as it is not
> needed anymore.
> You should use <button is="gaia-icon-button" icon="close"></button> (see such
> button on GAIA screen
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> )
> "gaia-icon-button" encapsulates all needed CSS styles for focused, active and
> hover states. So you only need to position it and set a color (with "color"
CSS
> property).
> Correct color for dark background is 'white', for white background -- rgba(0,
0,
> 0, .54).

Done

> 2. I think we should hide the button on the last step of flow. This can be
done
> in setVisiblePage_ method.

Done

[achuithb, 2015-05-15 22:10:56]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[achuithb, 2015-05-15 22:10:57]

The patchset sent to the CQ was uploaded after l-g-t-m from antrim@chromium.org
Link to the patchset: https://codereview.chromium.org/1131683004/#ps90001
(title: "Pavel feedback, and rebase")

[achuithb, 2015-05-15 22:11:12]

Please excuse the rebase

[commit-bot: I haz the power, 2015-05-15 22:12:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131683004/90001

[dzhioev (left Google), 2015-05-15 22:22:43]

LGTM with nit

https://codereview.chromium.org/1131683004/diff/90001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
(right):

https://codereview.chromium.org/1131683004/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html:162:
icon="close" i18n-values="aria-label:closeButton" tabindex="0"></button>
nit:
put </button> on a new line. From style guide: "If you linebreak after an
opening tag you must linebreak before the closing tag."

[achuithb, 2015-05-15 22:43:13]

Thanks!

https://codereview.chromium.org/1131683004/diff/90001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
(right):

https://codereview.chromium.org/1131683004/diff/90001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html:162:
icon="close" i18n-values="aria-label:closeButton" tabindex="0"></button>
On 2015/05/15 22:22:43, dzhioev wrote:
> nit:
> put </button> on a new line. From style guide: "If you linebreak after an
> opening tag you must linebreak before the closing tag."

Done.

[achuithb, 2015-05-15 22:43:29]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2015-05-15 22:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from antrim@chromium.org,
dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1131683004/#ps100001
(title: "linebreak closing tag")

[commit-bot: I haz the power, 2015-05-15 22:45:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131683004/100001

[commit-bot: I haz the power, 2015-05-15 23:33:05]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-05-18 11:29:06]

Patchset 4 (id:??) landed as
https://crrev.com/f54b8097a9c45ed4ad308133d49f05325d6c5070
Cr-Commit-Position: refs/heads/master@{#330231}

[soko.boss75, 2017-09-06 18:40:56]

soko.boss75@gmail.com changed reviewers:
+ soko.boss75@gmail.com

[soko.boss75, 2017-09-06 18:40:57]

lgtm