chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html - Issue 1131683004: Add close button to the supervised user pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html

Issue 1131683004: Add close button to the supervised user pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pavel feedback, and rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css ('k') | chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <link rel="import" href="chrome://oobe/custom_elements.html">

1 <div class="step hidden" id="supervised-user-creation" hidden>	2 <div class="step hidden" id="supervised-user-creation" hidden>

2 <div class="step-contents">	3 <div class="step-contents">

3 <div id="supervised-user-creation-intro" class="step-no-logo">	4 <div id="supervised-user-creation-intro" class="step-no-logo">

4 <div id="supervised-user-creation-marketing-intro"	5 <div id="supervised-user-creation-marketing-intro"

5 class="marketing">	6 class="marketing">

6 <img src="chrome://theme/IDR_SUPERVISED_ILLUSTRATION_START" alt="">	7 <img src="chrome://theme/IDR_SUPERVISED_ILLUSTRATION_START" alt="">

7 </div>	8 </div>

8 <div class="below-marketing">	9 <div class="below-marketing">

9 <div class="page-title"	10 <div class="page-title"

10 i18n-content="createSupervisedUserIntroTextTitle">	11 i18n-content="createSupervisedUserIntroTextTitle">

(...skipping 139 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
150 </div>	151 </div>

151 <div class="password-block" hidden>	152 <div class="password-block" hidden>

152 <input class="supervised-user-creation-manager-password" type="password"	153 <input class="supervised-user-creation-manager-password" type="password"

153 i18n-values="placeholder:createSupervisedUserManagerPasswordHint" />	154 i18n-values="placeholder:createSupervisedUserManagerPasswordHint" />

154 </div>	155 </div>

155 </div>	156 </div>

156 <div id="supervised-user-creation-import-template" hidden class="import-pod">	157 <div id="supervised-user-creation-import-template" hidden class="import-pod">

157 <img class="import-pod-image"></img>	158 <img class="import-pod-image"></img>

158 <div class="import-pod-name"></div>	159 <div class="import-pod-name"></div>

159 </div>	160 </div>

	161 <button id="supervised-user-creation-close-button-item" is="gaia-icon-button"

	162 icon="close" i18n-values="aria-label:closeButton" tabindex="0"></button>
	dzhioev (left Google) 2015/05/15 22:22:43 nit: put </button> on a new line. From style guide nit: put </button> on a new line. From style guide: "If you linebreak after an opening tag you must linebreak before the closing tag." achuithb 2015/05/15 22:43:13 Done. Show quoted text On 2015/05/15 22:22:43, dzhioev wrote: > nit: > put </button> on a new line. From style guide: "If you linebreak after an > opening tag you must linebreak before the closing tag." Done.
160 </div>	163 </div>

OLD	NEW