Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: remoting/host/heartbeat_sender_unittest.cc

Issue 1131653002: Use lower-case JIDs when generating signatures for messages sent to CRD bot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/heartbeat_sender.cc ('k') | remoting/host/register_support_host_request.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/heartbeat_sender.h" 5 #include "remoting/host/heartbeat_sender.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 20 matching lines...) Expand all
31 using testing::NotNull; 31 using testing::NotNull;
32 using testing::Return; 32 using testing::Return;
33 using testing::SaveArg; 33 using testing::SaveArg;
34 34
35 namespace remoting { 35 namespace remoting {
36 36
37 namespace { 37 namespace {
38 38
39 const char kTestBotJid[] = "remotingunittest@bot.talk.google.com"; 39 const char kTestBotJid[] = "remotingunittest@bot.talk.google.com";
40 const char kHostId[] = "0"; 40 const char kHostId[] = "0";
41 const char kTestJid[] = "user@gmail.com/chromoting123"; 41 const char kTestJid[] = "User@gmail.com/chromotingABC123";
42 const char kTestJidNormalized[] = "user@gmail.com/chromotingABC123";
42 const char kStanzaId[] = "123"; 43 const char kStanzaId[] = "123";
43 const int kTestInterval = 123; 44 const int kTestInterval = 123;
44 const base::TimeDelta kTestTimeout = base::TimeDelta::FromSeconds(123); 45 const base::TimeDelta kTestTimeout = base::TimeDelta::FromSeconds(123);
45 46
46 } // namespace 47 } // namespace
47 48
48 ACTION_P(AddListener, list) { 49 ACTION_P(AddListener, list) {
49 list->insert(arg0); 50 list->insert(arg0);
50 } 51 }
51 ACTION_P(RemoveListener, list) { 52 ACTION_P(RemoveListener, list) {
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 EXPECT_EQ(std::string(kHostId), 356 EXPECT_EQ(std::string(kHostId),
356 heartbeat_stanza->Attr(QName(kChromotingXmlNamespace, "hostid"))); 357 heartbeat_stanza->Attr(QName(kChromotingXmlNamespace, "hostid")));
357 358
358 QName signature_tag(kChromotingXmlNamespace, "signature"); 359 QName signature_tag(kChromotingXmlNamespace, "signature");
359 XmlElement* signature = heartbeat_stanza->FirstNamed(signature_tag); 360 XmlElement* signature = heartbeat_stanza->FirstNamed(signature_tag);
360 ASSERT_TRUE(signature != nullptr); 361 ASSERT_TRUE(signature != nullptr);
361 EXPECT_TRUE(heartbeat_stanza->NextNamed(signature_tag) == nullptr); 362 EXPECT_TRUE(heartbeat_stanza->NextNamed(signature_tag) == nullptr);
362 363
363 scoped_refptr<RsaKeyPair> key_pair = RsaKeyPair::FromString(kTestRsaKeyPair); 364 scoped_refptr<RsaKeyPair> key_pair = RsaKeyPair::FromString(kTestRsaKeyPair);
364 ASSERT_TRUE(key_pair.get()); 365 ASSERT_TRUE(key_pair.get());
365 std::string expected_signature = 366 std::string expected_signature = key_pair->SignMessage(
366 key_pair->SignMessage(std::string(kTestJid) + ' ' + expected_sequence_id); 367 std::string(kTestJidNormalized) + ' ' + expected_sequence_id);
367 EXPECT_EQ(expected_signature, signature->BodyText()); 368 EXPECT_EQ(expected_signature, signature->BodyText());
368 } 369 }
369 370
370 } // namespace remoting 371 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/host/heartbeat_sender.cc ('k') | remoting/host/register_support_host_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698