Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 1131643003: Update toolchain setup instructions to match reality. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Update toolchain setup instructions to match reality. BUG=none NOTRY=true NOPRESUBMIT=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
Nico
5 years, 7 months ago (2015-05-06 17:47:40 UTC) #2
scottmg
thanks! lgtm
5 years, 7 months ago (2015-05-06 17:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
5 years, 7 months ago (2015-05-06 17:49:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tools_build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/tools_build_presubmit/builds/54)
5 years, 7 months ago (2015-05-06 17:51:24 UTC) #7
Nico
I made this in my regular depot_tools checkout (where my gclient is)…does that not work ...
5 years, 7 months ago (2015-05-06 18:48:13 UTC) #8
scottmg
On 2015/05/06 18:48:13, Nico wrote: > I made this in my regular depot_tools checkout (where ...
5 years, 7 months ago (2015-05-06 18:50:46 UTC) #9
Dirk Pranke
On 2015/05/06 18:50:46, scottmg wrote: > On 2015/05/06 18:48:13, Nico wrote: > > I made ...
5 years, 7 months ago (2015-05-06 18:59:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
5 years, 7 months ago (2015-05-06 19:30:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tools_build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/tools_build_presubmit/builds/62)
5 years, 7 months ago (2015-05-06 19:32:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
5 years, 7 months ago (2015-05-06 19:48:34 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:48:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295155

Powered by Google App Engine
This is Rietveld 408576698