|
|
Chromium Code Reviews|
Created:
5 years, 7 months ago by Nico Modified:
5 years, 7 months ago Reviewers:
scottmg CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
tools Visibility:
Public. |
DescriptionUpdate toolchain setup instructions to match reality.
BUG=none
NOTRY=true
NOPRESUBMIT=true
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295155
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
thakis@chromium.org changed reviewers: + scottmg@chromium.org
thanks! lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tools_build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/tools_build_pre...)
I made this in my regular depot_tools checkout (where my gclient is)…does that not work for making depot_tools CLs?
On 2015/05/06 18:48:13, Nico wrote: > I made this in my regular depot_tools checkout (where my gclient is)…does that > not work for making depot_tools CLs? That's what I normally do. I'm not sure what it's complaining about. dpranke, iannucci?
On 2015/05/06 18:50:46, scottmg wrote: > On 2015/05/06 18:48:13, Nico wrote: > > I made this in my regular depot_tools checkout (where my gclient is)…does that > > not work for making depot_tools CLs? > > That's what I normally do. I'm not sure what it's complaining about. dpranke, > iannucci? It looks like the bot is trying to apply the patch to the build/ repo, which isn't going to work, obviously. I don't know why it's doing that, or when we started running tests on depot_tools; I'm guessing this is a misconfigured CQ. I would send a note to infra-dev@ and just bypass the failures (NOTRY=true).
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tools_build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/tools_build_pre...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131643003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295155 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
