Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 11316330: Revert 170701 since the WebKit change has now been rolled in again. (Closed)

Created:
8 years ago by tommi (sloooow) - chröme
Modified:
8 years ago
Reviewers:
tasak
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chromium-apps-reviews_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Revert 170701 since the WebKit change has now been rolled in again. > Revert 170668 > Needs to revert this because its WebKit patch was unrolled. > (See r136319, unreviewed, rolling out r136236). > > Update the Speech Api to support array(s) of result items > > instead of a single item at a time. > > > > BUG=143124 > > TEST=Covered by content_unittests > > > > Review URL: https://chromiumcodereview.appspot.com/11421103 > > TBR=tommi@chromium.org > Review URL: https://codereview.chromium.org/11416310 TBR=tasak@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -193 lines) Patch
MM chrome/browser/speech/chrome_speech_recognition_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/speech/speech_input_extension_apitest.cc View 1 chunk +3 lines, -1 line 0 comments Download
MM chrome/browser/speech/speech_input_extension_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
MM chrome/browser/speech/speech_input_extension_manager.cc View 2 chunks +26 lines, -21 lines 0 comments Download
M content/browser/speech/google_one_shot_remote_engine.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/speech/google_one_shot_remote_engine_unittest.cc View 5 chunks +24 lines, -18 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine_unittest.cc View 15 chunks +59 lines, -39 lines 0 comments Download
M content/browser/speech/input_tag_speech_dispatcher_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/speech/input_tag_speech_dispatcher_host.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognition_engine.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM content/browser/speech/speech_recognition_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
MM content/browser/speech/speech_recognizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM content/browser/speech/speech_recognizer.cc View 3 chunks +29 lines, -15 lines 0 comments Download
MM content/browser/speech/speech_recognizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM content/common/speech_recognition_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM content/public/browser/speech_recognition_event_listener.h View 2 chunks +4 lines, -4 lines 0 comments Download
MM content/public/common/speech_recognition_result.h View 1 chunk +2 lines, -0 lines 0 comments Download
MM content/renderer/input_tag_speech_dispatcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
MM content/renderer/input_tag_speech_dispatcher.cc View 3 chunks +21 lines, -17 lines 0 comments Download
MM content/renderer/speech_recognition_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
MM content/renderer/speech_recognition_dispatcher.cc View 2 chunks +46 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tommi (sloooow) - chröme
8 years ago (2012-12-04 09:54:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698