Issue 11416310: Revert 170668

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416310: Revert 170668 (Closed)

Created:
8 years ago by tasak

Modified:
8 years ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chromium-apps-reviews_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 170668 Needs to revert this because its WebKit patch was unrolled. (See r136319, unreviewed, rolling out r136236). > Update the Speech Api to support array(s) of result items > instead of a single item at a time. > > BUG=143124 > TEST=Covered by content_unittests > > Review URL: https://chromiumcodereview.appspot.com/11421103 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170701

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -278 lines)			Patch
M	chrome/browser/speech/chrome_speech_recognition_manager_delegate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/speech/speech_input_extension_apitest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/speech/speech_input_extension_manager.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/speech/speech_input_extension_manager.cc	View	2 chunks	+21 lines, -26 lines	0 comments	Download
M	content/browser/speech/google_one_shot_remote_engine.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	content/browser/speech/google_one_shot_remote_engine_unittest.cc	View	5 chunks	+18 lines, -24 lines	0 comments	Download
M	content/browser/speech/google_streaming_remote_engine.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	content/browser/speech/google_streaming_remote_engine_unittest.cc	View	15 chunks	+39 lines, -59 lines	0 comments	Download
M	content/browser/speech/input_tag_speech_dispatcher_host.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/speech/input_tag_speech_dispatcher_host.cc	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	content/browser/speech/speech_recognition_browsertest.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	content/browser/speech/speech_recognition_dispatcher_host.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognition_dispatcher_host.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/speech/speech_recognition_engine.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/speech/speech_recognition_manager_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognition_manager_impl.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View	3 chunks	+15 lines, -29 lines	0 comments	Download
M	content/browser/speech/speech_recognizer_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/speech_recognition_messages.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/public/browser/speech_recognition_event_listener.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/public/common/speech_recognition_result.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/input_tag_speech_dispatcher.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/renderer/input_tag_speech_dispatcher.cc	View	3 chunks	+17 lines, -21 lines	0 comments	Download
M	content/renderer/speech_recognition_dispatcher.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	content/renderer/speech_recognition_dispatcher.cc	View	2 chunks	+23 lines, -46 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages