Implement an IsAllowed function in the pepper PPB_Broker_Trusted API

ppapi/tests/test_broker.cc

Index: ppapi/tests/test_broker.cc
diff --git a/ppapi/tests/test_broker.cc b/ppapi/tests/test_broker.cc
index 63bbd1cee5dd6d6aef4f1f4f19401bc739b90d70..6b94445a5e1cbb204d26176f017a7f8c4e46b89c 100644
--- a/ppapi/tests/test_broker.cc
+++ b/ppapi/tests/test_broker.cc
@@ -222,6 +222,8 @@ void TestBroker::RunTests(const std::string& filter) {
 
   RUN_TEST(ConnectPermissionDenied, filter);
   RUN_TEST(ConnectPermissionGranted, filter);
+  RUN_TEST(IsAllowedPermissionDenied, filter);
+  RUN_TEST(IsAllowedPermissionGranted, filter);
 }
 
 std::string TestBroker::TestCreate() {
@@ -317,3 +319,20 @@ std::string TestBroker::TestConnectPermissionGranted() {
   PASS();
 }
 
+std::string TestBroker::TestIsAllowedPermissionDenied() {
+  PP_Resource broker = broker_interface_->CreateTrusted(

[yzshen1, 2012/12/06 19:59:46]

Is this leaked?

[raymes, 2012/12/07 21:32:19]

Good catch. But this is the case with all of the tests in this file. Rather than
changing it in this CL I'd rather put a TODO to write a C++ wrapper which will
handle the cleanup for us. Let me know if that's ok with you.

[yzshen1, 2012/12/07 21:54:34]

You can use the raw C interface PPB_Core to release this ref.

I don't think it is a lot of code. But if you prefer a later CL, that is fine.

On 2012/12/07 21:32:19, raymes wrote:

+      instance_->pp_instance());
+  ASSERT_TRUE(broker);
+  ASSERT_EQ(PP_FALSE, broker_interface_->IsAllowed(broker));
+
+  PASS();
+}
+
+std::string TestBroker::TestIsAllowedPermissionGranted() {
+  PP_Resource broker = broker_interface_->CreateTrusted(

[yzshen1, 2012/12/06 19:59:46]

Is this leaked?

[raymes, 2012/12/07 21:32:19]

As above.

+      instance_->pp_instance());
+  ASSERT_TRUE(broker);
+  ASSERT_EQ(PP_TRUE, broker_interface_->IsAllowed(broker));
+
+  PASS();
+}