Implement an IsAllowed function in the pepper PPB_Broker_Trusted API

ppapi/tests/test_broker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_broker.h"
 
 #if defined(_MSC_VER)
 #define OS_WIN 1
 #include <windows.h>
 #else
@@ skipping 204 matching lines @@
   RUN_TEST_FORCEASYNC_AND_NOT(ConnectFailure, filter);
   RUN_TEST_FORCEASYNC_AND_NOT(ConnectAndPipe, filter);
 
   // The following tests require special setup, so only run them if they're
   // explicitly specified by the filter.
   if (filter.empty())
     return;
 
   RUN_TEST(ConnectPermissionDenied, filter);
   RUN_TEST(ConnectPermissionGranted, filter);
+  RUN_TEST(IsAllowedPermissionDenied, filter);
+  RUN_TEST(IsAllowedPermissionGranted, filter);
 }
 
 std::string TestBroker::TestCreate() {
   // Very simplistic test to make sure we can create a broker interface.
   PP_Resource broker = broker_interface_->CreateTrusted(
       instance_->pp_instance());
   ASSERT_TRUE(broker);
 
   ASSERT_FALSE(broker_interface_->IsBrokerTrusted(0));
   ASSERT_TRUE(broker_interface_->IsBrokerTrusted(broker));
@@ skipping 75 matching lines @@
 
   TestCompletionCallback callback(instance_->pp_instance(), callback_type());
   callback.WaitForResult(broker_interface_->Connect(broker,
       callback.GetCallback().pp_completion_callback()));
   CHECK_CALLBACK_BEHAVIOR(callback);
   ASSERT_EQ(PP_OK, callback.result());
 
   PASS();
 }
 
+std::string TestBroker::TestIsAllowedPermissionDenied() {
+  PP_Resource broker = broker_interface_->CreateTrusted(

[yzshen1, 2012/12/06 19:59:46]

Is this leaked?

[raymes, 2012/12/07 21:32:19]

Good catch. But this is the case with all of the tests in this file. Rather than
changing it in this CL I'd rather put a TODO to write a C++ wrapper which will
handle the cleanup for us. Let me know if that's ok with you.

[yzshen1, 2012/12/07 21:54:34]

You can use the raw C interface PPB_Core to release this ref.

I don't think it is a lot of code. But if you prefer a later CL, that is fine.

On 2012/12/07 21:32:19, raymes wrote:

+      instance_->pp_instance());
+  ASSERT_TRUE(broker);
+  ASSERT_EQ(PP_FALSE, broker_interface_->IsAllowed(broker));
+
+  PASS();
+}
+
+std::string TestBroker::TestIsAllowedPermissionGranted() {
+  PP_Resource broker = broker_interface_->CreateTrusted(

[yzshen1, 2012/12/06 19:59:46]

Is this leaked?

[raymes, 2012/12/07 21:32:19]

As above.

+      instance_->pp_instance());
+  ASSERT_TRUE(broker);
+  ASSERT_EQ(PP_TRUE, broker_interface_->IsAllowed(broker));
+
+  PASS();
+}