Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316287: Move WindowModalityController to CoreWm. (Closed)

Created:
8 years ago by Ben Goodger (Google)
Modified:
8 years ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move WindowModalityController to CoreWm. I left the unittest in ash still for the time being as it requires a bunch of stuff from ash too (mostly the activation logic which is still in progress for Corewm). http://crbug.com/162100 R=rouslan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170679

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -706 lines) Patch
M ash/ash.gyp View 1 2 3 4 chunks +1 line, -7 lines 0 comments Download
M ash/shell.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
D ash/test/capture_tracking_view.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D ash/test/capture_tracking_view.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D ash/test/child_modal_window.h View 1 2 3 1 chunk +0 lines, -79 lines 0 comments Download
D ash/test/child_modal_window.cc View 1 2 3 1 chunk +0 lines, -214 lines 0 comments Download
M ash/wm/activation_controller.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/ash_activation_controller.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
D ash/wm/window_modality_controller.h View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download
D ash/wm/window_modality_controller.cc View 1 2 3 1 chunk +0 lines, -160 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 2 3 9 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/test/test_activation_client.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + ui/views/corewm/window_modality_controller.h View 1 2 3 2 chunks +13 lines, -14 lines 0 comments Download
A + ui/views/corewm/window_modality_controller.cc View 1 2 3 4 chunks +7 lines, -9 lines 0 comments Download
A + ui/views/test/capture_tracking_view.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/views/test/capture_tracking_view.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/views/test/child_modal_window.h View 1 2 3 3 chunks +20 lines, -23 lines 0 comments Download
A + ui/views/test/child_modal_window.cc View 1 2 3 10 chunks +25 lines, -26 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
8 years ago (2012-11-30 21:58:31 UTC) #1
please use gerrit instead
FWIW LGTM :-)
8 years ago (2012-11-30 22:25:05 UTC) #2
Ben Goodger (Google)
Now over to sadrul.
8 years ago (2012-11-30 22:51:58 UTC) #3
sadrul
8 years ago (2012-11-30 23:00:42 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698