Implement ComplexFeature to support permission features with multiple rules.

chrome/common/extensions/api/extension_api.h

Index: chrome/common/extensions/api/extension_api.h
diff --git a/chrome/common/extensions/api/extension_api.h b/chrome/common/extensions/api/extension_api.h
index b74bdccdb90b0057d2d3354a001b716029ce0ef7..4c4cf0dd730fc94a7848bc29bfa052e88ca30794 100644
--- a/chrome/common/extensions/api/extension_api.h
+++ b/chrome/common/extensions/api/extension_api.h
@@ -17,6 +17,7 @@
 #include "base/values.h"
 #include "chrome/common/extensions/features/feature.h"
 #include "chrome/common/extensions/features/feature_provider.h"
+#include "chrome/common/extensions/features/simple_feature.h"
 #include "extensions/common/url_pattern_set.h"
 
 namespace base {
@@ -94,7 +95,7 @@ class ExtensionAPI : public FeatureProvider {
   // Gets a Feature object describing the API with the specified |full_name|.
   // This can be either an API namespace (like history, or
   // experimental.bookmarks), or it can be an individual function or event.
-  virtual Feature* GetFeature(const std::string& full_name) OVERRIDE;
+  virtual SimpleFeature* GetFeature(const std::string& full_name) OVERRIDE;

[not at google - send to devlin, 2012/12/12 17:42:41]

should return a Feature?

[justinlin, 2012/12/14 12:26:26]

Done.

 
   // Splits a full name from the extension API into its API and child name
   // parts. Some examples:
@@ -173,7 +174,7 @@ class ExtensionAPI : public FeatureProvider {
   // APIs that have URL matching permissions.
   std::map<std::string, URLPatternSet> url_matching_apis_;
 
-  typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
+  typedef std::map<std::string, linked_ptr<SimpleFeature> > FeatureMap;

[not at google - send to devlin, 2012/12/12 17:42:41]

Feature?

[justinlin, 2012/12/14 12:26:26]

Done.

   typedef std::map<std::string, linked_ptr<FeatureMap> > APIFeatureMap;
   APIFeatureMap features_;