Implement ComplexFeature to support permission features with multiple rules.

chrome/common/extensions/api/extension_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
 #define CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/string_piece.h"
 #include "base/values.h"
 #include "chrome/common/extensions/features/feature.h"
 #include "chrome/common/extensions/features/feature_provider.h"
+#include "chrome/common/extensions/features/simple_feature.h"
 #include "extensions/common/url_pattern_set.h"
 
 namespace base {
 class DictionaryValue;
 class ListValue;
 class Value;
 }
 
 class GURL;
 
@@ skipping 57 matching lines @@
 
   // Gets the APIs available to |context| given an |extension| and |url|. The
   // extension or URL may not be relevant to all contexts, and may be left
   // NULL/empty.
   scoped_ptr<std::set<std::string> > GetAPIsForContext(
       Feature::Context context, const Extension* extension, const GURL& url);
 
   // Gets a Feature object describing the API with the specified |full_name|.
   // This can be either an API namespace (like history, or
   // experimental.bookmarks), or it can be an individual function or event.
-  virtual Feature* GetFeature(const std::string& full_name) OVERRIDE;
+  virtual SimpleFeature* GetFeature(const std::string& full_name) OVERRIDE;

[not at google - send to devlin, 2012/12/12 17:42:41]

should return a Feature?

[justinlin, 2012/12/14 12:26:26]

Done.

 
   // Splits a full name from the extension API into its API and child name
   // parts. Some examples:
   //
   // "bookmarks.create" -> ("bookmarks", "create")
   // "experimental.input.ui.cursorUp" -> ("experimental.input.ui", "cursorUp")
   // "storage.sync.set" -> ("storage", "sync.get")
   // "<unknown-api>.monkey" -> ("", "")
   //
   // The |child_name| parameter can be be NULL if you don't need that part.
@@ skipping 58 matching lines @@
 
   // APIs that are entirely unprivileged.
   std::set<std::string> completely_unprivileged_apis_;
 
   // APIs that are not entirely unprivileged, but have unprivileged components.
   std::set<std::string> partially_unprivileged_apis_;
 
   // APIs that have URL matching permissions.
   std::map<std::string, URLPatternSet> url_matching_apis_;
 
-  typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
+  typedef std::map<std::string, linked_ptr<SimpleFeature> > FeatureMap;

[not at google - send to devlin, 2012/12/12 17:42:41]

Feature?

[justinlin, 2012/12/14 12:26:26]

Done.

   typedef std::map<std::string, linked_ptr<FeatureMap> > APIFeatureMap;
   APIFeatureMap features_;
 
   // FeatureProviders used for resolving dependencies.
   typedef std::map<std::string, FeatureProvider*> FeatureProviderMap;
   FeatureProviderMap dependency_providers_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAPI);
 };
 
 }  // extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_