Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 11316066: Merge 167311 - Print headers and footers with WebKit. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka corp
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), darin-cc_chromium.org
Visibility:
Public.

Description

Merge 167311 - Print headers and footers with WebKit. Old implementation with gfx::RenderText had issues with fallback fonts. Sandbox does not allow to read required information from registry. Also WebKit inplementation is smaller and more readable. BUG=152893, 108599, 133548 TEST=manual: make sure that main content with or without headers is in the same place (default margin is exception). Make sure that any custom margins and paper layout produce reasonable result. If margins are to small, header and footer should be hidden. Review URL: https://chromiumcodereview.appspot.com/11359020 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -295 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/print_preview/print_preview_page.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 3 chunks +78 lines, -224 lines 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/renderer/print_web_view_helper_mac.mm View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 1 chunk +13 lines, -6 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +0 lines, -5 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M printing/print_settings_initializer.cc View 1 chunk +3 lines, -22 lines 0 comments Download
M printing/units.h View 1 chunk +0 lines, -4 lines 0 comments Download
M printing/units.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vitaly Buka corp
6 years, 6 months ago (2012-11-17 04:44:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698