Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6904)

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 11316057: Omnibox: Log Elapsed Time Since Last Time The Default Match Changed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/metrics/proto/omnibox_event.proto
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto
index dc1b77a49839b93476913233e3874f737b20b4d5..bc816d9293698421f3b53a5790c5259499cc1873 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/chrome/common/metrics/proto/omnibox_event.proto
@@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME;
package metrics;
-// Next tag: 13
+// Next tag: 14
message OmniboxEventProto {
// The timestamp for the event, in seconds since the epoch.
optional int64 time = 1;
@@ -49,6 +49,15 @@ message OmniboxEventProto {
// from the time of the second series of modification.
optional int64 typing_duration_ms = 7;
+ // The amount of time, in milliseconds, since the last time the default
+ // (inline) match changed. This may be longer than the time since the
+ // last keystroke. (The last keystroke may not have changed the default
+ // match.) It may also be shorter than the time since the last keystroke
+ // because the default match might have come from an asynchronous
+ // provider. Regardless, it should always be less than the field
Bart N. 2012/11/19 18:02:21 less -> less or equal?
Mark P 2012/11/19 22:21:45 Good point. Revised.
+ // |typing_duration_ms|.
+ optional int64 duration_since_last_default_match_update_ms = 13;
+
// The type of page currently displayed when the user used the omnibox.
enum PageClassification {
INVALID_SPEC = 0; // invalid URI; shouldn't happen

Powered by Google App Engine
This is Rietveld 408576698