Omnibox: Log Elapsed Time Since Last Time The Default Match Changed

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index 188611d51c8d59bf58b73013b81d2d9bb9549725..f5ae42936c8d0a48c40880813d905139ac2b2f8c 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -552,12 +552,19 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
                      web_contents()->GetURL()),
         base::TimeTicks::Now() - time_user_first_modified_omnibox_,
         string16::npos,  // inline autocomplete length; possibly set later
+        base::TimeTicks::Now() -

[Bart N., 2012/11/19 18:02:21]

There is some inconsistency here, because you call Now() twice. A better
approach would be to set Now() to a local variable and use it here and above.

[Mark P, 2012/11/19 22:21:45]

I was wondering if someone would call me out on this.  Switched to using a
temporary local variable.

+            autocomplete_controller_->last_time_default_match_changed(),
         result());
     DCHECK(user_input_in_progress_ ||
            match.provider->type() == AutocompleteProvider::TYPE_ZERO_SUGGEST)
         << "We didn't get here through the expected series of calls. "
         << "time_user_first_modified_omnibox_ is not set correctly and other "
         << "things may be wrong. Match provider: " << match.provider->GetName();
+    DCHECK(log.elapsed_time_since_user_first_modified_omnibox >=

[Peter Kasting, 2012/11/16 23:57:18]

Nit: DCHECK_GE

[Mark P, 2012/11/19 22:21:45]

Can't use a DCHECK_GE because DCHECK using << to display its parameters to an
output stream, and these TimeTicks variables have no toString() function.

+           log.elapsed_time_since_last_change_to_default_match)
+        << "We should've got the notification that the user modified the "
+        << "omnibox text at same time or before the most recent time the "
+        << "default match changed.";
     if (index != OmniboxPopupModel::kNoMatch)
       log.selected_index = index;
     else if (!has_temporary_text_)