Move ParameterKind so it can be used in the element model

Move ParameterKind so it can be used in the element model
Committed: https://code.google.com/p/dart/source/detail?r=14972

[messick, 2012-11-15 18:00:18]

lgtm

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
File editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF (right):

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF:34:
com.google.dart.engine.utilities.dart,
I've never been a fan of repeating a word in a FQN. Would "common" suit, instead
of the suffix "dart"? Or perhaps com.google.dart.engine.common?

[Brian Wilkerson, 2012-11-15 18:21:13]

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
File editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF (right):

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF:34:
com.google.dart.engine.utilities.dart,
> I've never been a fan of repeating a word in a FQN.

Didn't think about that. I have no objection to changing it, but I'm going to
put it off to a separate CL because I have no confidence that GCL can handle
that kind of change correctly.

[scheglov, 2012-11-16 03:25:25]

lgtm

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java
(right):

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java:16:
import com.google.dart.engine.utilities.dart.ParameterKind;
Hm...
Can we keep all AST parts in "ast" package and Element parts in "element"
package?
Leave ParameterKind in "ast" package, or create new ParameterKind in "element"
package if we don't want to have references from "ast" to "element" or from
"element" to "ast".

[Brian Wilkerson, 2012-11-16 15:55:02]

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java
(right):

http://codereview.chromium.org/11316019/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java:16:
import com.google.dart.engine.utilities.dart.ParameterKind;
> Can we keep all AST parts in "ast" package and Element parts in "element"
> package?

Not without duplicating code, which I am loath to do.

> Leave ParameterKind in "ast" package, or create new ParameterKind in "element"
> package if we don't want to have references from "ast" to "element" or from
> "element" to "ast".

Steve and I discussed this at length. I'm open to changing the decision, but I
don't really like any of the alternatives: duplicating the code makes it easy
for the code to get out of sync (and yes, I expect this to need to be updated),
and there is no single choice of package that really feels right. I only put it
where it is because it seemed like the least bad of all the choices I could
think of.