Move ParameterKind so it can be used in the element model

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java
===================================================================
--- editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java	(revision 14967)
+++ editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java	(working copy)
@@ -13,6 +13,8 @@
  */
 package com.google.dart.engine.ast;
 
+import com.google.dart.engine.utilities.dart.ParameterKind;

[scheglov, 2012/11/16 03:25:26]

Hm...
Can we keep all AST parts in "ast" package and Element parts in "element"
package?
Leave ParameterKind in "ast" package, or create new ParameterKind in "element"
package if we don't want to have references from "ast" to "element" or from
"element" to "ast".

[Brian Wilkerson, 2012/11/16 15:55:02]

Not without duplicating code, which I am loath to do.
Steve and I discussed this at length. I'm open to changing the decision, but I
don't really like any of the alternatives: duplicating the code makes it easy
for the code to get out of sync (and yes, I expect this to need to be updated),
and there is no single choice of package that really feels right. I only put it
where it is because it seemed like the least bad of all the choices I could
think of.

+
 /**
  * The abstract class {@code FormalParameter} defines the behavior of objects representing a
  * parameter to a function.
@@ -26,40 +28,6 @@
  */
 public abstract class FormalParameter extends ASTNode {
   /**
-   * The enumeration {@code ParameterKind} defines the different kinds of parameters. There are two
-   * basic kinds of parameters: required and optional. Optional parameters are further divided into
-   * two kinds: positional optional and named optional.
-   */
-  public enum ParameterKind {
-    REQUIRED(false),
-    POSITIONAL(true),
-    NAMED(true);
-
-    /**
-     * A flag indicating whether this is an optional parameter.
-     */
-    private boolean isOptional;
-
-    /**
-     * Initialize a newly created kind with the given state.
-     * 
-     * @param isOptional {@code true} if this is an optional parameter
-     */
-    private ParameterKind(boolean isOptional) {
-      this.isOptional = isOptional;
-    }
-
-    /**
-     * Return {@code true} if this is an optional parameter.
-     * 
-     * @return {@code true} if this is an optional parameter
-     */
-    public boolean isOptional() {
-      return isOptional;
-    }
-  }
-
-  /**
    * Return the kind of this parameter.
    * 
    * @return the kind of this parameter