Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 11316005: Merge 131315 - Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when (Closed)

Created:
8 years, 1 month ago by karen
Modified:
8 years, 1 month ago
Reviewers:
Jay Civelli
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 131315 - Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when its current position is at a segment boundary (4096) ends up adding an unitialized segment (with uninitialized memory) to the SharedBuffer. https://bugs.webkit.org/show_bug.cgi?id=99000 Reviewed by Adam Barth. Source/WebCore: * platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append): LayoutTests: * mhtml/shared_buffer_bug-expected.txt: Added. * mhtml/shared_buffer_bug.mht: Added. TBR=jcivelli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A + LayoutTests/mhtml/shared_buffer_bug.mht View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/mhtml/shared_buffer_bug-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/SharedBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
8 years, 1 month ago (2012-10-26 17:50:57 UTC) #1
Jay Civelli
8 years, 1 month ago (2012-10-26 18:48:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698