Issue 1131523006: Fix loadUrl for javascript urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131523006: Fix loadUrl for javascript urls. (Closed)

Created:
5 years, 7 months ago by gsennton

Modified:
5 years, 7 months ago

Reviewers:
Torne

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix loadUrl for javascript urls. A recent update https://codereview.chromium.org/1022993002 broke the loading of javascript URLs. This patch reverts only the part of the update which is broken. NOPRESUBMIT=true NOTRY=true BUG=489259 (cherry picked from commit 22abb71d9c3f0d6ed7f7252385e49673ad5c5fea)

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131523006/1

5 years, 7 months ago (2015-05-19 16:45:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages