chrome/browser/extensions/updater/extension_updater_unittest.cc - Issue 1131493004: Switch //chrome functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 1131493004: Switch //chrome functions to use SchemeIsCryptographic() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/updater/extension_updater_unittest.cc

diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc

index 0efe0f61a4b67d25fc95c5bc100b6844bdd12bbb..e4b7b7bd7e8ba315c41f05c7f68f80a79f857f4b 100644

--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc

+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc

@@ -1312,7 +1312,7 @@ class ExtensionUpdaterTest : public testing::Test {

net::HttpRequestHeaders fetch_headers;

fetcher->GetExtraRequestHeaders(&fetch_headers);

// If the download URL is not https, no credentials should be provided.

- if (!test_url.SchemeIsSecure()) {

+ if (!test_url.SchemeIsCryptographic()) {

// No cookies.

EXPECT_EQ(kExpectedLoadFlags, fetcher->GetLoadFlags());

// No Authorization header.

« no previous file with comments | « no previous file | chrome/browser/search/search.cc » ('j') | chrome/browser/signin/signin_header_helper.cc » ('J')