chrome/browser/signin/signin_header_helper.cc - Issue 1131493004: Switch //chrome functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_header_helper.cc

Issue 1131493004: Switch //chrome functions to use SchemeIsCryptographic() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/ui/toolbar/toolbar_model_unittest.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_header_helper.cc

diff --git a/chrome/browser/signin/signin_header_helper.cc b/chrome/browser/signin/signin_header_helper.cc

index 4f9807c083cec54ca793a9fa1d8a5ec108632109..187a6c332cf3af6b8f3d161b55389675cec7d347 100644

--- a/chrome/browser/signin/signin_header_helper.cc

+++ b/chrome/browser/signin/signin_header_helper.cc

@@ -173,7 +173,7 @@ void ProcessMirrorHeaderUIThread(

#endif // !defined(OS_IOS)

bool IsDriveOrigin(const GURL& url) {

- if (!url.SchemeIsSecure())

+ if (!url.SchemeIsCryptographic())

lgarron 2015/05/07 22:53:45 This seems a bit redundant, considering we're dire

return false;

const GURL kGoogleDriveURL("https://drive.google.com");