Chromium Code Reviews
Help | Chromium Project | Sign in
(838)

Issue 11314013: Register a separate default ui::EventTarget for Aura (Ash) to ensure that it does not interfere wit… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by ananta
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Register a separate default ui::EventTarget for Aura (Ash) to ensure that it does not interfere with the
event handling in desktop chrome in Aura.

On Windows 8 in chrome metro mode we have a desktop chrome process
which runs as a server to the viewer process in Metro. Reusing the default EventTarget across both environments
causes desktop chrome to crash as a number of EventFilters registered on the default EventTarget get called twice.

The Ash specific EventTarget is implemented by the Ash::Shell class. The RootWindow in its GetParentTarget implementation
delegates this call to the EventClient implementation if one exists and if not it returns the default Aura::Env interface.

The EventClient interface is implemented by Ash and has been updated to return the default EventTarget via the new method
GetToplevelEventTarget

Fixes bug http://code.google.com/p/chromium/issues/detail?id=158105

BUG=158105
R=ben
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164703

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Lint Patch
M ash/shell.h View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments 0 errors Download
M ash/shell.cc View 1 2 3 4 2 chunks +10 lines, -2 lines 0 comments 0 errors Download
M ash/wm/event_client_impl.h View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M ash/wm/event_client_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M ui/aura/client/event_client.h View 1 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window.cc View 1 1 chunk +3 lines, -1 line 0 comments 0 errors Download
M ui/aura/root_window_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
ananta
1 year, 5 months ago #1
Ben Goodger (Google)
https://codereview.chromium.org/11314013/diff/1/ui/aura/root_window.cc File ui/aura/root_window.cc (right): https://codereview.chromium.org/11314013/diff/1/ui/aura/root_window.cc#newcode489 ui/aura/root_window.cc:489: if (parent_event_target_) instead of doing this can we add ...
1 year, 5 months ago #2
ananta
https://codereview.chromium.org/11314013/diff/1/ui/aura/root_window.cc File ui/aura/root_window.cc (right): https://codereview.chromium.org/11314013/diff/1/ui/aura/root_window.cc#newcode489 ui/aura/root_window.cc:489: if (parent_event_target_) On 2012/10/26 21:51:57, Ben Goodger (Google) wrote: ...
1 year, 5 months ago #3
Ben Goodger (Google)
1 year, 5 months ago #4
lgtm

https://codereview.chromium.org/11314013/diff/7004/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/11314013/diff/7004/ash/shell.h#newcode197
ash/shell.h:197: // Overridden from ui::EventTarget:
move these to be the last functions in the private section, and be sure to move
the implementations in the .cc too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6