Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5343)

Unified Diff: chrome/test/data/third_party/spaceport/README.chromium

Issue 11314012: Add spaceport benchmark to Chrome Remote Control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/third_party/spaceport/js/tests/sprites.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/third_party/spaceport/README.chromium
diff --git a/chrome/test/data/third_party/spaceport/README.chromium b/chrome/test/data/third_party/spaceport/README.chromium
index becb12a34cb1f7c36103cac6550adea7253660c9..7e43261be5bc31de953e79879f84fbdf283a33b8 100644
--- a/chrome/test/data/third_party/spaceport/README.chromium
+++ b/chrome/test/data/third_party/spaceport/README.chromium
@@ -15,7 +15,7 @@ Modifications to the test suite to enable running as a cross browser performance
How to update:
-In js/index.js, change the 'step' attribute to add the required console.log
+1. In js/index.js, change the 'step' attribute to add the required console.log
statements. Below is the patch.
diff --git a/js/index.js b/js/index.js
@@ -49,3 +49,20 @@ index 2c23d0d..059a57a 100644
runPerformanceTests(function (err, results) {
if (err) return callback(err);
+
+2. In js/tests/sprites.js, apply the below patch to keep too many objects from
+being created on fast desktop machines.
+
+diff --git a/chrome/test/data/third_party/spaceport/js/tests/sprites.js b/chrome/test/data/third_party/spaceport/js/tests/s
+index b491fe6..64b2d03 100644
+--- a/chrome/test/data/third_party/spaceport/js/tests/sprites.js
++++ b/chrome/test/data/third_party/spaceport/js/tests/sprites.js
+@@ -168,7 +168,7 @@ define([ 'sprites/sources', 'sprites/transformers', 'sprites/renderers', 'util/e
+ rawData.push([ objectCount, results ]);
+
+ var timePerObjectEstimate = 1/(objectCount*results.fps);
+- var estimatedMaxObjects = Math.floor(1/(targetFramerate * timePerObjectEstimate));
++ var estimatedMaxObjects = Math.min(5000, Math.floor(1/(targetFramerate * timePerObjectEstimate)));
+
+ var nextObjectCount = nextNumberToTry(fpsResults, estimatedMaxObjects);
+ test(nextObjectCount);
« no previous file with comments | « no previous file | chrome/test/data/third_party/spaceport/js/tests/sprites.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698