Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5523)

Unified Diff: cc/tiles/picture_layer_tiling_unittest.cc

Issue 1131383007: cc: Ensure that skewport.Contains(visible_rect) is always true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/picture_layer_tiling.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/picture_layer_tiling_unittest.cc
diff --git a/cc/tiles/picture_layer_tiling_unittest.cc b/cc/tiles/picture_layer_tiling_unittest.cc
index 3539b6daba3066a6a9ae778eea76a5fff795aff5..31caf461d2acbedbf6d66804d4e5edd1926e2c51 100644
--- a/cc/tiles/picture_layer_tiling_unittest.cc
+++ b/cc/tiles/picture_layer_tiling_unittest.cc
@@ -629,6 +629,30 @@ TEST(PictureLayerTilingTest, SkewportLimits) {
EXPECT_TRUE(move_skewport_far.Contains(gfx::Rect(0, 5000, 100, 100)));
}
+TEST(PictureLayerTilingTest, ComputeSkewportExtremeCases) {
+ FakePictureLayerTilingClient client;
+
+ gfx::Size layer_bounds(200, 200);
+ client.SetTileSize(gfx::Size(100, 100));
+ LayerTreeSettings settings;
+ scoped_refptr<FakePicturePileImpl> pile =
+ FakePicturePileImpl::CreateFilledPileWithDefaultTileSize(layer_bounds);
+ scoped_ptr<TestablePictureLayerTiling> tiling =
+ TestablePictureLayerTiling::Create(ACTIVE_TREE, 1.0f, pile, &client,
+ settings);
+
+ gfx::Rect viewport1(-1918, 255860, 4010, 2356);
+ gfx::Rect viewport2(-7088, -91738, 14212, 8350);
+ gfx::Rect viewport3(-12730024, -158883296, 24607540, 14454512);
+ double time = 1.0;
+ tiling->ComputeTilePriorityRects(viewport1, 1.f, time, Occlusion());
+ time += 0.016;
+ EXPECT_TRUE(tiling->ComputeSkewport(time, viewport2).Contains(viewport2));
+ tiling->ComputeTilePriorityRects(viewport2, 1.f, time, Occlusion());
+ time += 0.016;
+ EXPECT_TRUE(tiling->ComputeSkewport(time, viewport3).Contains(viewport3));
+}
+
TEST(PictureLayerTilingTest, ComputeSkewport) {
FakePictureLayerTilingClient client;
« no previous file with comments | « cc/tiles/picture_layer_tiling.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698