Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1131383007: cc: Ensure that skewport.Contains(visible_rect) is always true. (Closed)

Created:
5 years, 7 months ago by vmpstr
Modified:
5 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Ensure that skewport.Contains(visible_rect) is always true. This patch ensures that the skewport contains the visible rect. This is a required that could be violated by extreme visible rects that would overflow integer math. The fix is to add an extra union. Includes a test. R=enne BUG=487130 Committed: https://crrev.com/7923e436272f671334bc4d75edad97c67bc02212 Cr-Commit-Position: refs/heads/master@{#330600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M cc/tiles/picture_layer_tiling.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/tiles/picture_layer_tiling_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 7 months ago (2015-05-19 19:43:52 UTC) #1
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-19 19:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131383007/1
5 years, 7 months ago (2015-05-19 19:50:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 20:44:39 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:45:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7923e436272f671334bc4d75edad97c67bc02212
Cr-Commit-Position: refs/heads/master@{#330600}

Powered by Google App Engine
This is Rietveld 408576698