Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131373005: Have shelldb and skydb automatically download assets for you (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
Hixie, eseidel1, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Have shelldb and skydb automatically download assets for you if they don't exist. BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/84009a30105043b08acbd1aaea34a57fd5f3a331

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M sky/tools/shelldb View 1 2 chunks +15 lines, -1 line 0 comments Download
M sky/tools/skydb View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 7 months ago (2015-05-19 21:15:25 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1131373005/diff/1/sky/tools/shelldb File sky/tools/shelldb (right): https://codereview.chromium.org/1131373005/diff/1/sky/tools/shelldb#newcode141 sky/tools/shelldb:141: print('NOTE: Running `download_material_design_icons` for you.') logging.info('sky/assets/material-design-icons missing, running ...
5 years, 7 months ago (2015-05-19 21:17:14 UTC) #4
Cutch
https://codereview.chromium.org/1131373005/diff/1/sky/tools/shelldb File sky/tools/shelldb (right): https://codereview.chromium.org/1131373005/diff/1/sky/tools/shelldb#newcode141 sky/tools/shelldb:141: print('NOTE: Running `download_material_design_icons` for you.') On 2015/05/19 21:17:13, eseidel ...
5 years, 7 months ago (2015-05-19 21:21:53 UTC) #5
Cutch
5 years, 7 months ago (2015-05-19 21:23:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
84009a30105043b08acbd1aaea34a57fd5f3a331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698