Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: sky/tools/shelldb

Issue 1131373005: Have shelldb and skydb automatically download assets for you (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tools/skydb » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/shelldb
diff --git a/sky/tools/shelldb b/sky/tools/shelldb
index 026ec97c26bc29b48887b299a0fca3f2ed371bca..31f1f57c8d161bbd16b3076837cb06fb77a488b9 100755
--- a/sky/tools/shelldb
+++ b/sky/tools/shelldb
@@ -132,10 +132,22 @@ def dev_packages_root(build_dir):
return os.path.join(build_dir, 'gen', 'dart-pkg', 'packages')
+def ensure_assets_are_downloaded(build_dir):
+ sky_pkg_dir = os.path.join(build_dir, 'gen', 'dart-pkg', 'sky')
+ sky_pkg_lib_dir = os.path.join(sky_pkg_dir, 'lib')
+ sky_icons_dir = \
+ os.path.join(sky_pkg_lib_dir, 'assets', 'material-design-icons')
+ if not os.path.isdir(sky_icons_dir):
+ logging.info('NOTE: sky/assets/material-design-icons missing, '
+ 'Running `download_material_design_icons` for you.')
+ subprocess.check_call(
+ [os.path.join(sky_pkg_lib_dir, 'download_material_design_icons')])
+
+
class StartSky(object):
def add_subparser(self, subparsers):
start_parser = subparsers.add_parser('start',
- help='launch SKyShell.apk on the device')
+ help='launch SkyShell.apk on the device')
start_parser.add_argument('build_dir', type=str)
start_parser.add_argument('url_or_path', nargs='?', type=str,
default=DEFAULT_URL)
@@ -169,6 +181,8 @@ class StartSky(object):
print "'%s' does not exist?" % apk_path
return 2
+ ensure_assets_are_downloaded(args.build_dir)
+
packages_root = dev_packages_root(args.build_dir)
sky_server = self._sky_server_for_args(args, packages_root)
pids['sky_server_pid'] = sky_server.start()
« no previous file with comments | « no previous file | sky/tools/skydb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698