Add cross origin to Blink-driven preconnect

chrome/browser/net/preconnect.cc

Index: chrome/browser/net/preconnect.cc
diff --git a/chrome/browser/net/preconnect.cc b/chrome/browser/net/preconnect.cc
index 01cadcce243593d28125112e78316302de3cdd94..0b2837839b54655b201e0fee89a8154ac05d0111 100644
--- a/chrome/browser/net/preconnect.cc
+++ b/chrome/browser/net/preconnect.cc
@@ -33,7 +33,7 @@ void PreconnectOnUIThread(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&PreconnectOnIOThread, url, first_party_for_cookies,
-                 motivation, count, make_scoped_refptr(getter)));
+                 motivation, count, make_scoped_refptr(getter), false));
   return;
 }
 
@@ -43,7 +43,8 @@ void PreconnectOnIOThread(
     const GURL& first_party_for_cookies,
     UrlInfo::ResolutionMotivation motivation,
     int count,
-    net::URLRequestContextGetter* getter) {
+    net::URLRequestContextGetter* getter,
+    bool isAnonymous) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     LOG(DFATAL) << "This must be run only on the IO thread.";
     return;
@@ -68,7 +69,8 @@ void PreconnectOnIOThread(
                                        user_agent);
 
   net::NetworkDelegate* delegate = context->network_delegate();
-  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies))
+  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies)
+    || isAnonymous)

[Ryan Sleevi, 2015/06/10 19:30:41]

So this is wrong. You should be using the |load_flags|.

It's unfortunate, because this ends up duplicating the |web_url_request_info|
logic (
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/web_...
) but is the canonical 'correct' layering perspective.

That is, if cross-origin preconnect is requested, you should NOT set privacy
mode, but instead set DO_NOT_[SAVE/SEND]_COOKIES and DO_NOT_SEND_AUTH_DATA

[Yoav Weiss, 2015/06/11 12:55:14]

hmm, setting request_info.load_flags to the above flags results in preconnects
not being sent at all... :/

     request_info.privacy_mode = net::PRIVACY_MODE_ENABLED;
 
   // It almost doesn't matter whether we use net::LOWEST or net::HIGHEST