Add cross origin to Blink-driven preconnect

chrome/browser/net/preconnect.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/preconnect.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 15 matching lines @@
     const GURL& url,
     const GURL& first_party_for_cookies,
     UrlInfo::ResolutionMotivation motivation,
     int count,
     net::URLRequestContextGetter* getter) {
   // Prewarm connection to Search URL.
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&PreconnectOnIOThread, url, first_party_for_cookies,
-                 motivation, count, make_scoped_refptr(getter)));
+                 motivation, count, make_scoped_refptr(getter), false));
   return;
 }
 
 
 void PreconnectOnIOThread(
     const GURL& url,
     const GURL& first_party_for_cookies,
     UrlInfo::ResolutionMotivation motivation,
     int count,
-    net::URLRequestContextGetter* getter) {
+    net::URLRequestContextGetter* getter,
+    bool isAnonymous) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     LOG(DFATAL) << "This must be run only on the IO thread.";
     return;
   }
   if (!getter)
     return;
   // We are now commited to doing the async preconnection call.
   UMA_HISTOGRAM_ENUMERATION("Net.PreconnectMotivation", motivation,
                             UrlInfo::MAX_MOTIVATED);
 
   net::URLRequestContext* context = getter->GetURLRequestContext();
   net::HttpTransactionFactory* factory = context->http_transaction_factory();
   net::HttpNetworkSession* session = factory->GetSession();
 
   std::string user_agent;
   if (context->http_user_agent_settings())
     user_agent = context->http_user_agent_settings()->GetUserAgent();
   net::HttpRequestInfo request_info;
   request_info.url = url;
   request_info.method = "GET";
   request_info.extra_headers.SetHeader(net::HttpRequestHeaders::kUserAgent,
                                        user_agent);
 
   net::NetworkDelegate* delegate = context->network_delegate();
-  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies))
+  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies)
+    || isAnonymous)

[Ryan Sleevi, 2015/06/10 19:30:41]

So this is wrong. You should be using the |load_flags|.

It's unfortunate, because this ends up duplicating the |web_url_request_info|
logic (
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/web_...
) but is the canonical 'correct' layering perspective.

That is, if cross-origin preconnect is requested, you should NOT set privacy
mode, but instead set DO_NOT_[SAVE/SEND]_COOKIES and DO_NOT_SEND_AUTH_DATA

[Yoav Weiss, 2015/06/11 12:55:14]

hmm, setting request_info.load_flags to the above flags results in preconnects
not being sent at all... :/

     request_info.privacy_mode = net::PRIVACY_MODE_ENABLED;
 
   // It almost doesn't matter whether we use net::LOWEST or net::HIGHEST
   // priority here, as we won't make a request, and will surrender the created
   // socket to the pool as soon as we can.  However, we would like to mark the
   // speculative socket as such, and IF we use a net::LOWEST priority, and if
   // a navigation asked for a socket (after us) then it would get our socket,
   // and we'd get its later-arriving socket, which might make us record that
   // the speculation didn't help :-/.  By using net::HIGHEST, we ensure that
   // a socket is given to us if "we asked first" and this allows us to mark it
@@ skipping 29 matching lines @@
 
   // All preconnects should perform EV certificate verification.
   ssl_config.verify_ev_cert = true;
 
   net::HttpStreamFactory* http_stream_factory = session->http_stream_factory();
   http_stream_factory->PreconnectStreams(count, request_info, priority,
                                          ssl_config, ssl_config);
 }
 
 }  // namespace chrome_browser_net