Add cross origin to Blink-driven preconnect

net/socket/client_socket_pool_manager.cc

Index: net/socket/client_socket_pool_manager.cc
diff --git a/net/socket/client_socket_pool_manager.cc b/net/socket/client_socket_pool_manager.cc
index 7820cf9d9ab3d964ddc25a90a9b9d6059bc10fee..d527472dc400a476381bdebcf3dae744dd3644a9 100644
--- a/net/socket/client_socket_pool_manager.cc
+++ b/net/socket/client_socket_pool_manager.cc
@@ -215,8 +215,15 @@ int InitSocketPoolHelper(ClientSocketPoolManager::SocketGroupType group_type,
     }
   }
 
+  // Turn on privacy mode if it was enabled, or if the load flags indicate
+  // that credentials cannot be sent.
+  bool enable_privacy_mode = (load_flags & LOAD_DO_NOT_SEND_COOKIES) ||
+                             (load_flags & LOAD_DO_NOT_SAVE_COOKIES) ||
+                             (load_flags & LOAD_DO_NOT_SEND_AUTH_DATA) ||
+                             (privacy_mode == PRIVACY_MODE_ENABLED);

[mmenke, 2015/07/13 21:02:01]

We should have tests of this changed behavior.

[Yoav Weiss, 2015/07/13 22:11:38]

What's the best location and methodology for such tests? Are there current unit
tests for the socket pool manager?

[mmenke, 2015/07/13 22:30:16]

I may have to do a little digging to figure how to reasonably test this - happy
to do it, but may not be able to get back to you until tomorrow afternoon (Which
is why I didn't give more info in the first place).  Sorry for slowness.

+
   // Change group name if privacy mode is enabled.
-  if (privacy_mode == PRIVACY_MODE_ENABLED)
+  if (enable_privacy_mode)
     connection_group = "pm/" + connection_group;
 
   // Deal with SSL - which layers on top of any given proxy.