Add cross origin to Blink-driven preconnect

net/socket/client_socket_pool_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/client_socket_pool_manager.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 197 matching lines @@
         socks_version = '4';
       connection_group = base::StringPrintf(
           "socks%c/%s", socks_version, connection_group.c_str());
 
       socks_params = new SOCKSSocketParams(proxy_tcp_params,
                                            socks_version == '5',
                                            origin_host_port);
     }
   }
 
+  // Turn on privacy mode if it was enabled, or if the load flags indicate
+  // that credentials cannot be sent.
+  bool enable_privacy_mode = (load_flags & LOAD_DO_NOT_SEND_COOKIES) ||
+                             (load_flags & LOAD_DO_NOT_SAVE_COOKIES) ||
+                             (load_flags & LOAD_DO_NOT_SEND_AUTH_DATA) ||
+                             (privacy_mode == PRIVACY_MODE_ENABLED);

[mmenke, 2015/07/13 21:02:01]

We should have tests of this changed behavior.

[Yoav Weiss, 2015/07/13 22:11:38]

What's the best location and methodology for such tests? Are there current unit
tests for the socket pool manager?

[mmenke, 2015/07/13 22:30:16]

I may have to do a little digging to figure how to reasonably test this - happy
to do it, but may not be able to get back to you until tomorrow afternoon (Which
is why I didn't give more info in the first place).  Sorry for slowness.

+
   // Change group name if privacy mode is enabled.
-  if (privacy_mode == PRIVACY_MODE_ENABLED)
+  if (enable_privacy_mode)
     connection_group = "pm/" + connection_group;
 
   // Deal with SSL - which layers on top of any given proxy.
   if (using_ssl) {
     scoped_refptr<TransportSocketParams> ssl_tcp_params;
     if (proxy_info.is_direct()) {
       // Setup TCP params if non-proxied SSL connection.
       // Combine connect and write for SSL sockets in TCP FastOpen field trial.
       TransportSocketParams::CombineConnectAndWritePolicy
           combine_connect_and_write =
@@ skipping 257 matching lines @@
     int num_preconnect_streams) {
   return InitSocketPoolHelper(
       group_type, endpoint, request_extra_headers, request_load_flags,
       request_priority, session, proxy_info, expect_spdy, ssl_config_for_origin,
       ssl_config_for_proxy, /*force_tunnel=*/false, privacy_mode, net_log,
       num_preconnect_streams, NULL, HttpNetworkSession::NORMAL_SOCKET_POOL,
       OnHostResolutionCallback(), CompletionCallback());
 }
 
 }  // namespace net