Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1131233004: Fixes regression when opening tabs in background with pinned tabs (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes regression when opening tabs in background with pinned tabs If the active tab is pinned and you have at least one pinned tab after the active tab then we would end up opening new link clicks after the pinned tab regardless of the opener. This is a regression from https://codereview.chromium.org/836223004 . BUG=446997, 446998, 476038 TEST=covered by test now. R=pkasting@chromium.org Committed: https://crrev.com/cce040b21a2d7ed6ce36197f9c02407bee1c2c68 Cr-Commit-Position: refs/heads/master@{#329419}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : feedback #

Patch Set 4 : change comment so dont trigger copyright check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sky
5 years, 7 months ago (2015-05-11 17:38:17 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/1131233004/diff/20001/chrome/browser/ui/tabs/tab_strip_model_unittest.cc File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right): https://codereview.chromium.org/1131233004/diff/20001/chrome/browser/ui/tabs/tab_strip_model_unittest.cc#newcode2692 chrome/browser/ui/tabs/tab_strip_model_unittest.cc:2692: // Verifies ordering of tabs opened via link ...
5 years, 7 months ago (2015-05-11 22:10:32 UTC) #2
sky
https://codereview.chromium.org/1131233004/diff/20001/chrome/browser/ui/tabs/tab_strip_model_unittest.cc File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right): https://codereview.chromium.org/1131233004/diff/20001/chrome/browser/ui/tabs/tab_strip_model_unittest.cc#newcode2692 chrome/browser/ui/tabs/tab_strip_model_unittest.cc:2692: // Verifies ordering of tabs opened via link from ...
5 years, 7 months ago (2015-05-11 22:13:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131233004/40001
5 years, 7 months ago (2015-05-11 22:17:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62783)
5 years, 7 months ago (2015-05-11 22:27:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131233004/60001
5 years, 7 months ago (2015-05-12 15:55:35 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-12 16:43:14 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:44:03 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cce040b21a2d7ed6ce36197f9c02407bee1c2c68
Cr-Commit-Position: refs/heads/master@{#329419}

Powered by Google App Engine
This is Rietveld 408576698